Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Custom ca cert support #122

Merged
merged 23 commits into from
Jul 11, 2024
Merged

feat: Custom ca cert support #122

merged 23 commits into from
Jul 11, 2024

Conversation

jacobbmay
Copy link
Collaborator

No description provided.

@jacobbmay jacobbmay changed the title Custom c as Custom ca cert support Jun 4, 2024
@blancharda blancharda changed the title Custom ca cert support feat: Custom ca cert support Jun 4, 2024
This was referenced Jun 7, 2024
Open
Open
@jacobbmay jacobbmay marked this pull request as ready for review July 9, 2024 21:55
blancharda
blancharda reviewed Jul 10, 2024
View reviewed changes
bundles/uds-core-swf/uds-bundle.yaml Outdated
uds-nexus-config:
values:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate line fails the schema check

@blancharda blancharda mentioned this pull request Jul 10, 2024
Closed
anthonywendt
anthonywendt reviewed Jul 10, 2024
View reviewed changes
bundles/uds-core-swf/uds-bundle.yaml Outdated
value: *extra-volumes
- path: extraVolumeMounts
value: *extra-volume-mounts
# TODO: remove if not needed. Trying to updated trusted certs via container host first
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@blancharda
Copy link
Contributor

blancharda commented Jul 10, 2024 •
edited
Loading

We should investigate providing the custom CA to neuvector.

The chart doesn't appear to support extravolume/mounts -- but maybe there's another way to provide it.
A cursory look suggests maybe something would be possible by setting autoGenerateCert: false and then manually providing the TLS cert/ca to the individual components (controller, monitor, scanner, adapter and enforcer)

I'm comfortable with this being addressed after this PR -- but we should make an issue

@blancharda
Copy link
Contributor

Same goes for Velero^

This was referenced Jul 10, 2024
Closed
Open
blancharda
blancharda previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@blancharda blancharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to address in subsequent (or upstream) PRs (namely velero and neuvector) -- but this is a good start!

If we cut a release before addressing those^, we'll want to note it in the release.

blancharda
blancharda approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@blancharda blancharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@blancharda blancharda merged commit 4d90054 into main Jul 11, 2024
@blancharda blancharda deleted the CustomCAs branch July 11, 2024 18:52
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Merged
This was referenced Dec 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonywendt anthonywendt anthonywendt left review comments

@blancharda blancharda blancharda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobbmay @blancharda @anthonywendt